hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13873) LoadTestTool addAuthInfoToConf throws UnsupportedOperationException
Date Wed, 10 Jun 2015 16:46:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580775#comment-14580775
] 

Hudson commented on HBASE-13873:
--------------------------------

SUCCESS: Integrated in HBase-1.2 #142 (See [https://builds.apache.org/job/HBase-1.2/142/])
HBASE-13873 LoadTestTool addAuthInfoToConf throws UnsupportedOperationException (sunyerui)
(tedyu: rev d33e0acdd3e9f99e87a18288bfe29df612ac878c)
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java


> LoadTestTool addAuthInfoToConf throws UnsupportedOperationException
> -------------------------------------------------------------------
>
>                 Key: HBASE-13873
>                 URL: https://issues.apache.org/jira/browse/HBASE-13873
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>    Affects Versions: 0.98.13
>            Reporter: sunyerui
>            Assignee: sunyerui
>             Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13873-0.98.patch
>
>
> When run IntegrationTestIngestWithACL on distributed clusters with kerberos security
enabled, the method addAuthInfoToConf() in LoadTestTool will be invoked and throws UnsupportedOperationException,
stack as follows:
> {code}
> 2015-06-09 22:15:33,605 ERROR [main] util.AbstractHBaseTool: Error running command-line
tool
> java.lang.UnsupportedOperationException
>         at java.util.AbstractList.add(AbstractList.java:148)
>         at java.util.AbstractList.add(AbstractList.java:108)
>         at org.apache.hadoop.hbase.util.LoadTestTool.addAuthInfoToConf(LoadTestTool.java:811)
>         at org.apache.hadoop.hbase.util.LoadTestTool.loadTable(LoadTestTool.java:516)
>         at org.apache.hadoop.hbase.util.LoadTestTool.doWork(LoadTestTool.java:479)
>         at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
>         at org.apache.hadoop.hbase.IntegrationTestIngest.runIngestTest(IntegrationTestIngest.java:151)
>         at org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:114)
>         at org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:97)
>         at org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:115)
>         at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.hbase.IntegrationTestIngestWithACL.main(IntegrationTestIngestWithACL.java:136)
> {code}
> The corresponding code is below and the reason is obvious. Arrays.asList return a java.util.Arrays$ArrayList
but not java.util.ArrayList. Both of them are inherited from java.util.AbstractList, but the
former didn't override the method add(), so the parent method java.util.AbstractList.add()
will be invoked and the exception threw.
> {code}
> private void addAuthInfoToConf(Properties authConfig, Configuration conf, String owner,
>       String userList) throws IOException {
>     List<String> users = Arrays.asList(userList.split(","));
>     users.add(owner);
>     ...
>   }
> {code}
> Does anyone occurred on this? I think it's an obvious bug but no one report it, so please
tell me if I misunderstanding it. If it's actually a bug here, then it can be fixed very easy
as below:
> {code}
>  List<String> users = new ArrayList<String>(Arrays.asList(userList.split(",")));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message