hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13836) Do not reset the mvcc for bulk loaded mob reference cells in reading
Date Tue, 09 Jun 2015 10:05:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578660#comment-14578660

Anoop Sam John commented on HBASE-13836:

-    if (this.cur != null && this.reader.isBulkLoaded()) {
+    if (this.cur != null && !this.reader.isSkipResetSeqId()) {

It will be better for readability that this check is this.cur != null && this.reader.isBulkLoaded()
&&  !this.reader.isSkipResetSeqId()

Also no need to call setter on reader for non bulk loaded cases.. Just set it only for bulk
loaded files. And  pls add some comments that why we do this skip.

> Do not reset the mvcc for bulk loaded mob reference cells in reading
> --------------------------------------------------------------------
>                 Key: HBASE-13836
>                 URL: https://issues.apache.org/jira/browse/HBASE-13836
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mob
>    Affects Versions: hbase-11339
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>             Fix For: hbase-11339
>         Attachments: HBASE-13836.diff
> Now in scanner, the cells mvcc of the bulk loaded files are reset by the seqId parsed
from the file name. We need to skip this if the hfiles are bulkloaded in mob compactions.
> In mob compaction, the bulk loaded ref cell might not be the latest cell among the ones
that have the same row key. In reading, the mvcc is reset by the largest one, it will cover
the real latest ref cell. We have to skip the resetting in this case.
> The solution is we add a new field to fileinfo, when this field is set as true, we skip
the resetting.

This message was sent by Atlassian JIRA

View raw message