hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13834) Evict count not properly passed to HeapMemoryTuner.
Date Thu, 04 Jun 2015 07:43:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572322#comment-14572322
] 

Anoop Sam John commented on HBASE-13834:
----------------------------------------

Oh ..wrong math..
We dont need 3 state variables I guess.  One is enough
{code}
private long evictCount = 0L;
...
private void tune() {
  long latestEvictCount = blockCache.getStats().getEvictedCount();
  tunerContext.setEvictCount(latestEvictCount - evictCount);
  evictCount = latestEvictCount ;
..
}
{code}
Any chance for a test case?

> Evict count not properly passed to HeapMemoryTuner.
> ---------------------------------------------------
>
>                 Key: HBASE-13834
>                 URL: https://issues.apache.org/jira/browse/HBASE-13834
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase, regionserver
>    Affects Versions: 2.0.0
>            Reporter: Abhilash
>            Assignee: Abhilash
>            Priority: Trivial
>              Labels: easyfix
>         Attachments: EvictCountBug.patch, HBASE-13834.patch
>
>
> Evict count calculated inside the HeapMemoryManager class in tune function that is passed
to HeapMemoryTuner via TunerContext is miscalculated. It is supposed to be Evict count between
two intervals but its not. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message