hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13828) Add group permissions testing coverage to AC.
Date Tue, 09 Jun 2015 22:44:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579701#comment-14579701
] 

Andrew Purtell commented on HBASE-13828:
----------------------------------------

Don't call convertToGroup(String) every time we need an object. Make the test groups in setup
like we make the test users. 

---

The new constants look a bit strange because they don't follow how the others were named.

TESTGROUP_x -> Consider GROUP_xxx. Example: TESTGROUP_R -> GROUP_READ.

TESTGROUP_x_USER -> Consider USER_GROUP_xxx. Example: TESTGROUP_R_USER -> USER_GROUP_READ.

It's minor but it improves the readability of the test.

---

Patches look good otherwise.

> Add group permissions testing coverage to AC.
> ---------------------------------------------
>
>                 Key: HBASE-13828
>                 URL: https://issues.apache.org/jira/browse/HBASE-13828
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13828-0.98.patch, HBASE-13828-branch-1.0.patch, HBASE-13828-branch-1.1.patch,
HBASE-13828-branch-1.patch, HBASE-13828-v1.patch, HBASE-13828.patch
>
>
> We suffered a regression HBASE-13826 recently due to lack of testing coverage for group
permissions for AC. With the recent perf boost provided by HBASE-13658, it wouldn't be a bad
idea to add checks for group level users to applicable unit tests in TestAccessController.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message