hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13827) Delayed scanner close in KeyValueHeap and StoreScanner
Date Sat, 06 Jun 2015 05:40:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575598#comment-14575598

Hudson commented on HBASE-13827:

FAILURE: Integrated in HBase-TRUNK #6548 (See [https://builds.apache.org/job/HBase-TRUNK/6548/])
HBASE-13827 Delayed scanner close in KeyValueHeap and StoreScanner. (anoopsamjohn: rev fef6d7f48c81d63b12be4f53031bdbf208635cac)
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java

> Delayed scanner close in KeyValueHeap and StoreScanner
> ------------------------------------------------------
>                 Key: HBASE-13827
>                 URL: https://issues.apache.org/jira/browse/HBASE-13827
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-13827.patch, HBASE-13827.patch, HBASE-13827.patch
> This is to support the work in HBASE-12295. We have to return the blocks when the close()
happens on the HFileScanner.  Right now close is not at all there. Will add. The StoreFileScanner
will call it on its close().
> In KVHeap when we see one of the child scanner runs out of cells, we will remove them
from the PriorityQueue as well as close it. Also the same kind of stuff in StoreScanner too.
But when we want to do the return block in close() this kind of early close is not correct.
 Still there might be cells created out of these cached blocks.
> This Jira aims at changing these container scanners not to do early close. When it seems
a child scanner no longer required, it will avoid using it completely but just wont call close().
Instead it will be added to another list for a delayed close and that will be closed when
the container scanner close() happens.

This message was sent by Atlassian JIRA

View raw message