hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bhupendra Kumar Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13823) Procedure V2: unnecessaery operaions on AssignmentManager#recoverTableInDisablingState() and recoverTableInEnablingState()
Date Tue, 23 Jun 2015 10:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597430#comment-14597430
] 

Bhupendra Kumar Jain commented on HBASE-13823:
----------------------------------------------

In ActiveProcedureIterator class fetchNext() method 
{code}Procedure proc = null;
	      for (; index < (threads.length - 1) && proc != null; ++index) {
	        proc = ((Executor)threads[index]).getActiveProcedure();
	      }
{code}
The for loop condition will be always false as proc is null and it will never enter into loop.
I think it should be as {code}for (; index < (threads.length - 1) && proc == null;
++index) {code}

> Procedure V2: unnecessaery operaions on AssignmentManager#recoverTableInDisablingState()
and recoverTableInEnablingState()
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13823
>                 URL: https://issues.apache.org/jira/browse/HBASE-13823
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, proc-v2
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>         Attachments: HBASE-13823-v0.patch
>
>
> AssignmentManager#recoverTableInDisablingState() and AssignmentManager#recoverTableInEnablingState
try to complete unfinished enable/disable table operations.  In the past, it is necessary,
as master failure could leave table in bad state.  With HBASE-13211, enable/disable operations
would be auto-recover by Procedure-V2 logic.  Those recovery operation is not necessary: we
can either remove those recovery operation or not replay enable/disable operations in procedure
queue.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message