hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13817) ByteBufferOuputStream - add writeInt support
Date Thu, 04 Jun 2015 00:27:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571889#comment-14571889
] 

stack commented on HBASE-13817:
-------------------------------

bq. May be skip?

I'd say so. Just confuses.  Setting it though it is the default and we don't set it anywhere
else we do BB messing.  Sorry for my being fixated on this.

+1 after doing above. Just commit.

Thanks for adding the jmh.

> ByteBufferOuputStream - add writeInt support
> --------------------------------------------
>
>                 Key: HBASE-13817
>                 URL: https://issues.apache.org/jira/browse/HBASE-13817
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13817.patch, HBASE-13817_V2.patch, benchmark.zip
>
>
> While writing Cells to this stream, to make the CellBlock ByteBuffer, we do write length
of the cell as int. We use StreamUtils to do this which will write each byte one after the
other. So 4 write calls on Stream.(OutputSteam has only this support) With ByteBufferOuputStream
we have the overhead of checking for size limit and possible grow with every write call. Internally
this stream writes to a ByteBuffer. Again inside the ByteBuffer implementations there is position
limit checks.  If we do write these length as int in one go we can reduce this overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message