hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13755) Provide single super user check implementation
Date Thu, 04 Jun 2015 15:09:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572942#comment-14572942
] 

Anoop Sam John commented on HBASE-13755:
----------------------------------------

As long as we can throw Exception when used before initialize(Conf) it is fine.  Am not sure
whether the new class name is correct.. Am not good in naming.. :-(

checkSystemOrSuperUser(Configuration conf) 
Now conf is of no use. Just avoid passing as param

if (superUsers == null || superGroups == null) {
May be superUsers == null check would be enough.  Pls say in javadoc abt throws case

@InterfaceAudience.Public
Do we need to expose it as Public interface. Keep it private IMO.

> Provide single super user check implementation
> ----------------------------------------------
>
>                 Key: HBASE-13755
>                 URL: https://issues.apache.org/jira/browse/HBASE-13755
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Mikhail Antonov
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13755-v1.patch
>
>
> Followup for HBASE-13375.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message