hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13614) Avoid temp KeyOnlyKeyValue temp objects creations in read hot path
Date Fri, 19 Jun 2015 15:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593554#comment-14593554

Anoop Sam John commented on HBASE-13614:

Patch lgtm.
minor comments
public void setKey(byte[] key) 
Is this needed?  setKey(byte[], int, int) is enough right?

// TODO BufferedEncodedSeeker, instance will be used by single thread alone. So we can
// have one KeyValue.KeyOnlyKeyValue instance as instance variable and reuse here and in
// seekToKeyInBlock 
keyOnlyKV.setKey(current.keyBuffer, 0, current.keyLength);
Now it is done. Can remove the TODO

> Avoid temp KeyOnlyKeyValue temp objects creations in read hot path
> ------------------------------------------------------------------
>                 Key: HBASE-13614
>                 URL: https://issues.apache.org/jira/browse/HBASE-13614
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0
>         Attachments: HBASE-13614.patch, HBASE-13614_1.patch
> As part of HBASE-10800, move to new CellComparator, we are temp creating a Cell out of
byte[]s so that the Comparator can compare.  In read hot path, we can try minimize the object
creations. The parent Jira added some such cases, which we can solve.  This Jira will solve
all such cases.

This message was sent by Atlassian JIRA

View raw message