hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13451) Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use in the CellComparators
Date Fri, 05 Jun 2015 07:58:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574095#comment-14574095
] 

stack commented on HBASE-13451:
-------------------------------

Carrying over +1 from RB though before commit, please review we have test coverage for the
methods in new index readers... would be good to get bugs out in unit tests rather than out
in production context. If sufficient coverage, +1 on commit.

> Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use in the CellComparators
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13451
>                 URL: https://issues.apache.org/jira/browse/HBASE-13451
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13451.patch, HBASE-13451_1.patch, HBASE-13451_2.patch
>
>
> After HBASE-10800 we could ensure that all the blockKeys in the BlockReader are converted
to Cells (KeyOnlyKeyValue) so that we could use CellComparators. Note that this can be done
only for the keys that are written using CellComparators and not for the ones using RawBytesComparator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message