hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13451) Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use in the CellComparators
Date Mon, 08 Jun 2015 12:08:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577092#comment-14577092
] 

Hadoop QA commented on HBASE-13451:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12738338/HBASE-13451_5.patch
  against master branch at commit 9f43a3bea6a996a93f3c960801a0200b52419b34.
  ATTACHMENT ID: 12738338

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 28 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 17 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1929 checkstyle
errors (more than the master's current 1919 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      throw new UnsupportedOperationException("Cannot search for a key that is of Cell
type. Only plain byte array keys can be searched for");
+      throw new UnsupportedOperationException("Cannot find for a key containing plain byte
array. Only cell based keys can be searched for");

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestScanWithBloomError

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14327//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14327//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14327//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14327//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14327//console

This message is automatically generated.

> Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use in the CellComparators
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13451
>                 URL: https://issues.apache.org/jira/browse/HBASE-13451
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13451.patch, HBASE-13451_1.patch, HBASE-13451_2.patch, HBASE-13451_3.patch,
HBASE-13451_4.patch, HBASE-13451_5.patch
>
>
> After HBASE-10800 we could ensure that all the blockKeys in the BlockReader are converted
to Cells (KeyOnlyKeyValue) so that we could use CellComparators. Note that this can be done
only for the keys that are written using CellComparators and not for the ones using RawBytesComparator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message