Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 31 May 2015 01:01:17 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12834010.1433015616000.75526.1433034077731@Atlassian.JIRA>
In-Reply-To: <JIRA.12834010.1433015616000@Atlassian.JIRA>
References: <JIRA.12834010.1433015616000@Atlassian.JIRA>
 <JIRA.12834010.1433015616808@arcas>
Subject: [jira] [Commented] (HBASE-13815) Procedure V2: Rollback of
 CreateTableProcedure should clear the table state
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566279#comment-14566279 ] 

Hadoop QA commented on HBASE-13815:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736377/HBASE-13815.v1-branch-1.patch
  against branch-1 branch at commit ee30d050dc9112bc74eb02452bd9b3699d278f07.
  ATTACHMENT ID: 12736377

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.util.TestHBaseFsck

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14247//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14247//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14247//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14247//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14247//console

This message is automatically generated.

> Procedure V2: Rollback of CreateTableProcedure should clear the table state
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-13815
>                 URL: https://issues.apache.org/jira/browse/HBASE-13815
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>             Fix For: 2.0.0, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13815.v1-branch-1.patch, HBASE-13815.v1-master.patch
>
>
> If CreateTableProcedure rolls back, depending on the steps of the procedure, it might not change the table state to be 'Deleted' or just delete the table state.  
> In branch-1 and its child branches, the following exception will throw if the table is created again and the previous rollback is not clean:
> {noformat}
> 2015-05-30 06:30:05,287 WARN [ProcedureExecutorThread-1] procedure.CreateTableProcedure: The table xyz does not exist in meta but has a znode. run hbck to fix inconsistencies.
> {noformat}
> In master branch, the table state is not checked during CreateTableProcedure#prepareCreate(), but we still need to make sure that the table state is in a consistent state.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)