Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2DEFC18E53 for ; Thu, 21 May 2015 23:45:18 +0000 (UTC) Received: (qmail 92713 invoked by uid 500); 21 May 2015 23:45:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 92671 invoked by uid 500); 21 May 2015 23:45:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 92658 invoked by uid 99); 21 May 2015 23:45:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 May 2015 23:45:17 +0000 Date: Thu, 21 May 2015 23:45:17 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13733) Failed MiniZooKeeperCluster startup did not shutdown ZK servers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555294#comment-14555294 ] Hudson commented on HBASE-13733: -------------------------------- SUCCESS: Integrated in HBase-1.2 #97 (See [https://builds.apache.org/job/HBase-1.2/97/]) HBASE-13733 Failed MiniZooKeeperCluster startup did not shutdown ZK servers (Stephen Jiang) (tedyu: rev c695d1c2498c812fea727525f50939244c0f0cd1) * hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > Failed MiniZooKeeperCluster startup did not shutdown ZK servers > --------------------------------------------------------------- > > Key: HBASE-13733 > URL: https://issues.apache.org/jira/browse/HBASE-13733 > Project: HBase > Issue Type: Bug > Components: Zookeeper > Affects Versions: 2.0.0, 1.1.0, 1.2.0 > Reporter: Stephen Yuan Jiang > Assignee: Stephen Yuan Jiang > Fix For: 2.0.0, 1.2.0, 1.1.1 > > Attachments: HBASE-13733.v1.patch > > > MiniZooKeeperCluster#startup() starts servers one-by-one, if everything is good, it would declare success of start: > {code} > public int startup(File baseDir, int numZooKeeperServers) > ... > // running all the ZK servers > for (int i = 0; i < numZooKeeperServers; i++) { > ...===> could throw exception in the loop and end the startup > // Start up this ZK server > standaloneServerFactory.startup(server); > ... > standaloneServerFactoryList.add(standaloneServerFactory); > zooKeeperServers.add(server); > } > ... > started = true; > ... > } > {code} > However, if exception throws in the middle of start up (eg. some servers already started), the MiniZooKeeperCluster#shutdown() would not shut down them and clean up resources. > {code} > public void shutdown() throws IOException { > if (!started) { > return; > } > ... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)