Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40992179E1 for ; Wed, 20 May 2015 22:40:00 +0000 (UTC) Received: (qmail 9688 invoked by uid 500); 20 May 2015 22:40:00 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 9642 invoked by uid 500); 20 May 2015 22:40:00 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 9630 invoked by uid 99); 20 May 2015 22:40:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2015 22:40:00 +0000 Date: Wed, 20 May 2015 22:40:00 +0000 (UTC) From: "Esteban Gutierrez (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-13729) Old hbase.regionserver.global.memstore.upperLimit is ignored if present MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esteban Gutierrez updated HBASE-13729: -------------------------------------- Attachment: HBASE-13729.2.patch New patch handles lowerLimit as expected, just swapping the order is enough. > Old hbase.regionserver.global.memstore.upperLimit is ignored if present > ----------------------------------------------------------------------- > > Key: HBASE-13729 > URL: https://issues.apache.org/jira/browse/HBASE-13729 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 2.0.0, 1.0.1, 1.1.0 > Reporter: Esteban Gutierrez > Assignee: Esteban Gutierrez > Priority: Critical > Attachments: 0001-HBASE-13729-Old-hbase.regionserver.global.memstore.u.patch, HBASE-13729.2.patch > > > If hbase.regionserver.global.memstore.upperLimit is present we should use it instead of hbase.regionserver.global.memstore.size the current implementation of HeapMemorySizeUtil.getGlobalMemStorePercent() asumes that if hbase.regionserver.global.memstore.size is not defined thenit should use the old configuration, however it should be the other way around. > This has a large impact specially if doing a rolling upgrade of a cluster when the memstore upper limit has been changed from the default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)