Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAF1C180BC for ; Fri, 22 May 2015 07:38:17 +0000 (UTC) Received: (qmail 6785 invoked by uid 500); 22 May 2015 07:38:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 6730 invoked by uid 500); 22 May 2015 07:38:17 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 6718 invoked by uid 99); 22 May 2015 07:38:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2015 07:38:17 +0000 Date: Fri, 22 May 2015 07:38:17 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13703) ReplicateContext should not be a member of ReplicationSource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555763#comment-14555763 ] Hudson commented on HBASE-13703: -------------------------------- FAILURE: Integrated in HBase-1.1 #500 (See [https://builds.apache.org/job/HBase-1.1/500/]) HBASE-13703 ReplicateContext should not be a member of ReplicationSource. (larsh: rev 47c0105d65d3f1ec8ea5fdb0998f7c2965c09fa7) * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java > ReplicateContext should not be a member of ReplicationSource > ------------------------------------------------------------ > > Key: HBASE-13703 > URL: https://issues.apache.org/jira/browse/HBASE-13703 > Project: HBase > Issue Type: Bug > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Minor > Fix For: 2.0.0, 0.98.13, 1.0.2, 1.1.1 > > Attachments: 13703.txt > > > The ReplicateContext object is created once per ReplicationSource and then reused when we have something to ship to the sinks. > This is a misguided optimization. ReplicateContext is very lightweight (definitely compared to the all the work and copying the ReplicationSource is doing) and, crucially, it prevent the the entries array from being collected after it was successfully copied to the sink, wasting potentially a lot of heap. > The entries array itself holds reference to WAL entries on the heap, that now also cannot be collected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)