Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43A7B176DA for ; Mon, 18 May 2015 05:38:00 +0000 (UTC) Received: (qmail 64375 invoked by uid 500); 18 May 2015 05:38:00 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 64238 invoked by uid 500); 18 May 2015 05:38:00 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 64226 invoked by uid 99); 18 May 2015 05:38:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2015 05:38:00 +0000 Date: Mon, 18 May 2015 05:38:00 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13703) ReplicateContext should not be a member of ReplicationSource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547558#comment-14547558 ] ramkrishna.s.vasudevan commented on HBASE-13703: ------------------------------------------------ LGTM. The ReplicationContext is anyway passed to the ReplicationEndpoint and also the ReplicationSourceInterface does not try to create Replicationcontext as a member variable in the init() params. Also ReplicationContext object does not need any state variable from the ReplicatonSource where it is getting created (for now). Even VisibilityReplicationEndpoint just tries to use the ReplicationContext that is passed to it via the replicate(ReplicationContext) API. > ReplicateContext should not be a member of ReplicationSource > ------------------------------------------------------------ > > Key: HBASE-13703 > URL: https://issues.apache.org/jira/browse/HBASE-13703 > Project: HBase > Issue Type: Bug > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Minor > Attachments: 13703.txt > > > The ReplicateContext object is created once per ReplicationSource and then reused when we have something to ship to the sinks. > This is a misguided optimization. ReplicateContext is very lightweight (definitely compared to the all the work and copying the ReplicationSource is doing) and, crucially, it prevent the the entries array from being collected after it was successfully copied to the sink, wasting potentially a lot of heap. > The entries array itself holds reference to WAL entries on the heap, that now also cannot be collected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)