Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B80017663 for ; Sat, 30 May 2015 08:07:18 +0000 (UTC) Received: (qmail 11418 invoked by uid 500); 30 May 2015 08:07:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11374 invoked by uid 500); 30 May 2015 08:07:17 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11363 invoked by uid 99); 30 May 2015 08:07:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 May 2015 08:07:17 +0000 Date: Sat, 30 May 2015 08:07:17 +0000 (UTC) From: "Andrey Stepachev (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13647) Default value for hbase.client.operation.timeout is too high MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565885#comment-14565885 ] Andrey Stepachev commented on HBASE-13647: ------------------------------------------ [~enis] sure, lets fix that. did lookup for all places where this timeout used (for 2.0). || class || used for || should be || | AsyncRpcClient | as netty connection timeout | relates to sockets, so SOCKET_TIMEOUT_CONNECT is more appropriate | | HBaseAdmin | used for all calls like createTable | ideally it should be separate and much larger then 3-5 minutes | | HRegionServer | used for replica flush call | Integer.MAX not bad for this usecase | | RegionCoprocessorRpcChannel | used to call coprocessors | separate config option is better, but regular HBASE_RPC_TIMEOUT_KEY can suite well too | | RegionReplicaReplicationEndpoint | used to replicate WAL entries | separate config option is better to allow user to configure how long replication will retry to push WAL edits | | HTable (via TableConfiguration) | methods which not use AsyncProcess, as [~enis] mentioned before | HBASE_RPC_TIMEOUT_KEY is more appropriate as timeout | Taking into account this brief scan of usages it seems that we can set not very aggressive timeout to 5 or 10 minutes, but need to clean up this in separate jiras. > Default value for hbase.client.operation.timeout is too high > ------------------------------------------------------------ > > Key: HBASE-13647 > URL: https://issues.apache.org/jira/browse/HBASE-13647 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0, 1.0.1, 0.98.13, 1.2.0, 1.1.1 > Reporter: Andrey Stepachev > Assignee: Andrey Stepachev > Priority: Critical > Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 > > Attachments: HBASE-13647.patch > > > Default value for hbase.client.operation.timeout is too high, it is LONG.Max. > That value will block any service calls to coprocessor endpoints indefinitely. > Should we introduce better default value for that? -- This message was sent by Atlassian JIRA (v6.3.4#6332)