Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D654017453 for ; Thu, 14 May 2015 17:04:00 +0000 (UTC) Received: (qmail 17448 invoked by uid 500); 14 May 2015 17:04:00 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 17389 invoked by uid 500); 14 May 2015 17:04:00 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 17376 invoked by uid 99); 14 May 2015 17:04:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 17:04:00 +0000 Date: Thu, 14 May 2015 17:04:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13646) HRegion#execService should not try to build incomplete messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544026#comment-14544026 ] stack commented on HBASE-13646: ------------------------------- Go ahead and commit to branch-1 [~octo47] There is no gatekeeper/RM on branch-1 (Nick is gatekeeper on branch-1.1 and Enis on branch-1.0). > HRegion#execService should not try to build incomplete messages > --------------------------------------------------------------- > > Key: HBASE-13646 > URL: https://issues.apache.org/jira/browse/HBASE-13646 > Project: HBase > Issue Type: Bug > Components: Coprocessors, regionserver > Affects Versions: 2.0.0, 1.2.0, 1.1.1 > Reporter: Andrey Stepachev > Assignee: Andrey Stepachev > Fix For: 2.0.0 > > Attachments: HBASE-13646-branch-1.patch, HBASE-13646.patch, HBASE-13646.v2.patch, HBASE-13646.v2.patch > > > If some RPC service, called on region throws exception, execService still tries to build Message. In case of complex messages with required fields it complicates service code because service need to pass fake protobuf objects, so they can be barely buildable. > To mitigate that I propose to check that controller was failed and return null from call instead of failing with exception. -- This message was sent by Atlassian JIRA (v6.3.4#6332)