Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 19 May 2015 23:24:01 +0000 (UTC)
From: "Lars Francke (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12828267.1431068979000.163520.1432077841278@Atlassian.JIRA>
In-Reply-To: <JIRA.12828267.1431068979000@Atlassian.JIRA>
References: <JIRA.12828267.1431068979000@Atlassian.JIRA>
 <JIRA.12828267.1431068979054@arcas>
Subject: [jira] [Commented] (HBASE-13645) Rename *column methods in
 MasterObserver to *columnFamily
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551444#comment-14551444 ] 

Lars Francke commented on HBASE-13645:
--------------------------------------

The Checkstyle warnings are because I annotated the methods in all subclasses of MasterObserver as deprecated but didn't add Javadoc. The normal Javadoc is inherited but the deprecation warning is not. One solution would be to add @inheritDoc + @deprecation warnings everywhere but I think that's overkill.

The rest didn't run properly so I'll try to resubmit.

> Rename *column methods in MasterObserver to *columnFamily
> ---------------------------------------------------------
>
>                 Key: HBASE-13645
>                 URL: https://issues.apache.org/jira/browse/HBASE-13645
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HBASE-13645.patch, HBASE-13645.patch
>
>
> This being an interface makes it a bit harder on implementors. It'd be easier with Java8 and default implementations.
> We could either
> # add new *columnFamily methods and deprecate the old ones or
> # rename the existing ones without doing a deprecation first.
> Implementors would need to change their code in each of those cases. But because we have the {{BaseMasterObserver}} and {{BaseMasterAndRegionObserver}} it'd make things easier for people using those classes if we go with option 1. So that's my preference.
> The plan would be to add these methods in 2.0.0 and remove the old ones in 3.0.0.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)