Return-Path: 
 <issues-return-195088-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3574218DEF
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed,  6 May 2015 12:45:01 +0000 (UTC)
Received: (qmail 16231 invoked by uid 500); 6 May 2015 12:45:01 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 16188 invoked by uid 500); 6 May 2015 12:45:01 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 16177 invoked by uid 99); 6 May 2015 12:45:01 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2015 12:45:01 +0000
Date: Wed, 6 May 2015 12:45:00 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12826513.1430466298000.22823.1430916300937@Atlassian.JIRA>
In-Reply-To: <JIRA.12826513.1430466298000@Atlassian.JIRA>
References: <JIRA.12826513.1430466298000@Atlassian.JIRA>
 <JIRA.12826513.1430466298943@arcas>
Subject: [jira] [Updated] (HBASE-13606) AssignmentManager.assign() is not
 sync in both path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-13606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Bertozzi updated HBASE-13606:
------------------------------------
    Attachment: HBASE-13606-v3.patch

> AssignmentManager.assign() is not sync in both path
> ---------------------------------------------------
>
>                 Key: HBASE-13606
>                 URL: https://issues.apache.org/jira/browse/HBASE-13606
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 2.0.0, 1.1.0, 1.2.0
>
>         Attachments: HBASE-13606-v0.patch, HBASE-13606-v1-branch-1.patch, HBASE-13606-v1.patch, HBASE-13606-v2-branch-1.patch, HBASE-13606-v2.patch, HBASE-13606-v3.patch, TEST-org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure.xml
>
>
> from the comment and the expected behavior AssignmentManager.assign() should be sync
> {code}
> /** Assigns specified regions round robin, if any.
>  * This is a synchronous call and will return once every region has been
> public void assign(List<HRegionInfo> regions)
> {code}
> but the code has two path. 1 sync and the async
> {code}
> if (servers == 1 || (regions < bulkAssignThresholdRegions
>         && servers < bulkAssignThresholdServers)) {
>    for (HRegionInfo region: plan.getValue()) {
>      ...
>         invokeAssign(region);  // <-- this is async threadPool.submit(assign)
>      ...
>   }
> } else {
>   BulkAssigner ba = new GeneralBulkAssigner(...);
>   ba.bulkAssign();  // <-- this is sync, calls BulkAssign.waitUntilDone()
> }
> {code}
> https://builds.apache.org/job/HBase-1.1/452/ TestCreateTableProcedure is flaky because of this async behavior



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)