Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A12017513 for ; Tue, 5 May 2015 01:46:07 +0000 (UTC) Received: (qmail 63790 invoked by uid 500); 5 May 2015 01:46:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 63741 invoked by uid 500); 5 May 2015 01:46:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 63729 invoked by uid 99); 5 May 2015 01:46:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 01:46:06 +0000 Date: Tue, 5 May 2015 01:46:06 +0000 (UTC) From: "Jimmy Xiang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13605) RegionStates should not keep its list of dead servers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13605?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D145= 27748#comment-14527748 ]=20 Jimmy Xiang commented on HBASE-13605: ------------------------------------- The patch is fine with me for the master branch. For branch 1, I am not sur= e. > RegionStates should not keep its list of dead servers > ----------------------------------------------------- > > Key: HBASE-13605 > URL: https://issues.apache.org/jira/browse/HBASE-13605 > Project: HBase > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 2.0.0, 1.0.2, 1.1.1 > > Attachments: hbase-13605_v1.patch > > > As mentioned in https://issues.apache.org/jira/browse/HBASE-9514?focusedC= ommentId=3D13769761&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:= comment-tabpanel#comment-13769761 and HBASE-12844 we should have only 1 sou= rce of cluster membership.=20 > The list of dead server and RegionStates doing it's own liveliness check = (ServerManager.isServerReachable()) has caused an assignment problem again = in a test cluster where the region states "thinks" that the server is dead = and SSH will handle the region assignment. However the RS is not dead at al= l, living happily, and never gets zk expiry or YouAreDeadException or anyth= ing. This leaves the list of regions unassigned in OFFLINE state.=20 > master assigning the region: > {code} > 15-04-20 09:02:25,780 DEBUG [AM.ZK.Worker-pool3-t330] master.RegionStates= : Onlined 77dddcd50c22e56bfff133c0e1f9165b on os-amb-r6-us-1429512014-hbase= 4-6.novalocal,16020,1429520535268 {ENCODED =3D> 77dddcd50c > {code} > Master then disabled the table, and unassigned the region: > {code} > 2015-04-20 09:02:27,158 WARN [ProcedureExecutorThread-1] zookeeper.ZKTab= leStateManager: Moving table loadtest_d1 state from DISABLING to DISABLING > Starting unassign of loadtest_d1,,1429520544378.77dddcd50c22e56bfff133c0= e1f9165b. (offlining), current state: {77dddcd50c22e56bfff133c0e1f9165b sta= te=3DOPEN, ts=3D1429520545780, server=3Dos-amb-r6-us-1429512014-hbase4-6.= novalocal,16020,1429520535268} > bleProcedure$BulkDisabler-0] master.AssignmentManager: Sent CLOSE to os-a= mb-r6-us-1429512014-hbase4-6.novalocal,16020,1429520535268 for region loadt= est_d1,,1429520544378.77dddcd50c22e56bfff133c0e1f9165b. > 2015-04-20 09:02:27,414 INFO [AM.ZK.Worker-pool3-t316] master.RegionStat= es: Offlined 77dddcd50c22e56bfff133c0e1f9165b from os-amb-r6-us-1429512014-= hbase4-6.novalocal,16020,1429520535268 > {code} > On table re-enable, AM does not assign the region:=20 > {code} > 2015-04-20 09:02:30,415 INFO [ProcedureExecutorThread-3] balancer.BaseLo= adBalancer: Reassigned 25 regions. 25 retained the pre-restart assignment.= =C2=B7 > 2015-04-20 09:02:30,415 INFO [ProcedureExecutorThread-3] procedure.Enabl= eTableProcedure: Bulk assigning 25 region(s) across 5 server(s), retainAssi= gnment=3Dtrue > l,16000,1429515659726-GeneralBulkAssigner-4] master.RegionStates: Couldn'= t reach online server os-amb-r6-us-1429512014-hbase4-6.novalocal,16020,1429= 520535268 > l,16000,1429515659726-GeneralBulkAssigner-4] master.AssignmentManager: Up= dating the state to OFFLINE to allow to be reassigned by SSH > nmentManager: Skip assigning loadtest_d1,,1429520544378.77dddcd50c22e56bf= ff133c0e1f9165b., it is on a dead but not processed yet server: os-amb-r6-u= s-1429512014-hbase4-6.novalocal,16020,1429520535268 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)