Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 11 May 2015 05:01:00 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12822385.1429549968000.71210.1431320460895@Atlassian.JIRA>
In-Reply-To: <JIRA.12822385.1429549968000@Atlassian.JIRA>
References: <JIRA.12822385.1429549968000@Atlassian.JIRA>
 <JIRA.12822385.1429549968156@arcas>
Subject: [jira] [Commented] (HBASE-13510) Refactor Bloom filters to make use
 of Cell Comparators in case of ROW_COL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537566#comment-14537566 ] 

Anoop Sam John commented on HBASE-13510:
----------------------------------------

{code}
public static KeyValue createBloomKeyValue(byte[] row, int roffset, int rlength, byte[] qualifier,
	  int qoffset, int qlength) {
	if (qualifier == null)
	  qualifier = DUMMY;

	// Make sure this does not specify a timestamp so that the default maximum
	// (most recent) timestamp is used.
	return KeyValueUtil.createFirstOnRow(row, roffset, rlength, DUMMY, 0, 0, qualifier, qoffset,
		qlength);
}
{code}
Can we avoid this being a public util? I think just used in one place. Move this code piece directly where used?

> Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
> -------------------------------------------------------------------------
>
>                 Key: HBASE-13510
>                 URL: https://issues.apache.org/jira/browse/HBASE-13510
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13510_1.patch, HBASE-13510_2.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing Cell with a serialized KV's key we had some need for that in Bloom filters.  After discussing with Anoop, we found that it may be possible to remove/modify some of the APIs in the BloomFilter interfaces and for doing that we can purge ByteBloomFilter.  
> I read the code and found that ByteBloomFilter was getting used in V1 version only.  Now as it is obsolete we can remove this code and move some of the static APIs in ByteBloomFilter to some other util class or bloom related classes which will help us in refactoring the code too.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)