Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 1 May 2015 07:50:07 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12763496.1419354012000.44018.1430466607180@Atlassian.JIRA>
In-Reply-To: <JIRA.12763496.1419354012000@Atlassian.JIRA>
References: <JIRA.12763496.1419354012000@Atlassian.JIRA>
 <JIRA.12763496.1419354012824@arcas>
Subject: [jira] [Commented] (HBASE-12751) Allow RowLock to be reader writer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522899#comment-14522899 ] 

Hadoop QA commented on HBASE-12751:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12729721/HBASE-12751-v6.patch
  against master branch at commit 1d26d2640734b919d9bf266326e211be0478c711.
  ATTACHMENT ID: 12729721

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 98 new or modified tests.

		    {color:red}-1 Anti-pattern{color}.  The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted:
                      getRegionInfo(), -1, new TreeMap<byte[], List<Path>>());.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 5 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1920 checkstyle errors (more than the master's current 1898 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                this.htableDescriptor.getTableName(), WALKey.NO_SEQUENCE_ID, nonceGroup, nonce, mvcc);
+      long logSeqNum, final long now, List<UUID> clusterIds, long nonceGroup, long nonce, MultiVersionConsistencyControl mvcc) {
+      final long now, List<UUID> clusterIds, long nonceGroup, long nonce, final MultiVersionConsistencyControl mvcc) {
+      final long now, List<UUID> clusterIds, long nonceGroup, long nonce, MultiVersionConsistencyControl mvcc) {
+      long logSeqNum, final long now, List<UUID> clusterIds, long nonceGroup, long nonce, MultiVersionConsistencyControl mvcc) {
+                                                final WALProtos.BulkLoadDescriptor descriptor) throws IOException {
+      long logSeqNum, final long now, List<UUID> clusterIds, long nonceGroup, long nonce, MultiVersionConsistencyControl mvcc) {
+      long logSeqNum, final long now, List<UUID> clusterIds, long nonceGroup, long nonce, MultiVersionConsistencyControl mvcc) {

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestStoreFileRefresherChore

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13908//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13908//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13908//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13908//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13908//console

This message is automatically generated.

> Allow RowLock to be reader writer
> ---------------------------------
>
>                 Key: HBASE-12751
>                 URL: https://issues.apache.org/jira/browse/HBASE-12751
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-12751-v1.patch, HBASE-12751-v2.patch, HBASE-12751-v3.patch, HBASE-12751-v4.patch, HBASE-12751-v5.patch, HBASE-12751-v6.patch, HBASE-12751-v7.patch, HBASE-12751.patch
>
>
> Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios.
> If there are several puts to the same row but different columns or stores then this is very limiting.
> If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed.
> However locking for check and put or increment is still needed.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)