hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13784) Add Async Client Table API
Date Thu, 28 May 2015 21:30:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563727#comment-14563727
] 

stack commented on HBASE-13784:
-------------------------------

bq. With the work I am doing I was trying to change as little as possible to the current behaviour.

Fair enough.

Suggestions for what might be improved upon given your now intimate knowledge of rpc appreciated
as follow ons.

bq. Should I add an overall timeout to the RetryingResponsePromise? (It seems I forgot to
add a stop after max amount of retries has been reached in current patch)

Well, we have timeouts and retries now (after you fix the 'stop' missed in current patch?)
Adding another timeout in RetryingResponsePromise would be on top of these?

Thanks for taking a look at [~louiscryan]'s work.

bq.  I would like to propose a bit different and simpler Api than is currently implemented
in Table. 

No objection here.

We need these?

mutate(List<Mutation>): ResponsePromise<Void> - Will not accept Append and Increment
because of nonce requirement.
mutate(RowMutations): ResponsePromise<Void> - Will not accept Append and Increment
mutate(List<RowMutations>): ResponsePromise<Void> - Will not accept Append and
Increment

Is it just because Append and Increment are not Mutations? Lets fix that rather than do above?

How we fix it so you don't need RowMutation and Mutation?

Otherwise, all looks good (PromiseKeeping and changing scan... FYI, Scan has had a bunch of
work done since you were around last ... did you notice? It should be easier to fit it to
your new form that previous).

Suggest you float message on dev list to get more input on your new API set.

Nice work [~jurmous]



> Add Async Client Table API
> --------------------------
>
>                 Key: HBASE-13784
>                 URL: https://issues.apache.org/jira/browse/HBASE-13784
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-13784-v1.patch, HBASE-13784.patch
>
>
> With the introduction of the Async HBase RPC Client it is possible to create an Async
Table API and more. This issue is focussed on creating a first async Table API so it is possible
to do any non deprecated Table call in an async way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message