hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13759) Improve procedure yielding
Date Sun, 24 May 2015 22:06:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557862#comment-14557862

stack commented on HBASE-13759:

Do you want to ask the host if it is aborting or stopping in here handleInterruptedException?

The implementation of isYieldAfterExecutionStep is done by doing a isYieldBeforeExecuteFromState
in StateMachineProcedure? Interesting...

141	  protected boolean isYieldAfterExecutionStep(final TEnvironment env) {
142	    return isYieldBeforeExecuteFromState(env, getCurrentState());
143	  }

Patch LGTM. +1 after hadoopqa passes.

> Improve procedure yielding
> --------------------------
>                 Key: HBASE-13759
>                 URL: https://issues.apache.org/jira/browse/HBASE-13759
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0, 1.2.0
>         Attachments: HBASE-13759-v0.patch
> Adds the ability to yield the procedure every execution step.
> by default, a procedure will try to go begin to end without stopping.
> This allows procedures to be nice to other procedures.
> one usage example is ServerShutdownHandler where we want everyone to make some progress.
> Allows procedure to throw InterruptedException, the default handling will be:
> "ask the master if there is an abort of stop. If there is, stop executions and exit.
Else, clear the IE and carryon executing. the interruted procedure will retry".
> If the procedure implementor wants a different behavior, the IE can be catched and custom
handling can be performed.

This message was sent by Atlassian JIRA

View raw message