hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13754) Allow non KeyValue Cell types also to oswrite
Date Wed, 27 May 2015 18:55:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561495#comment-14561495
] 

stack commented on HBASE-13754:
-------------------------------

bq. we need the boolean withTags !!

Ok. Suggest you add an override then, a write that has not tags argument that defaults writing
tags if present otherwise, it writes out nothing.... and then a write that takes the tags
flag that can be used at the borders where tags are not allowed across.

> Allow non KeyValue Cell types also to oswrite
> ---------------------------------------------
>
>                 Key: HBASE-13754
>                 URL: https://issues.apache.org/jira/browse/HBASE-13754
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13754.patch
>
>
> While making the cellblock for returning data to client, we have to write the cell data
into an OutputStream. KeyValue has a static oswrite() method with which it can write data
in one go. (KeyValue components are in a single byte[]). For other cell implementation, we
will call getXXXLength() and getXXXArray() and write each component one after the other. This
is not efficient as the KeyValue way. In fact other cell impls also may have one contigous
byte[] backing for keys atleast. (See ClonedSeekerState) We can optimize for such Cells also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message