hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13733) Failed MiniZooKeeperCluster startup did not shutdown ZK servers
Date Thu, 21 May 2015 23:45:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555294#comment-14555294
] 

Hudson commented on HBASE-13733:
--------------------------------

SUCCESS: Integrated in HBase-1.2 #97 (See [https://builds.apache.org/job/HBase-1.2/97/])
HBASE-13733 Failed MiniZooKeeperCluster startup did not shutdown ZK servers (Stephen Jiang)
(tedyu: rev c695d1c2498c812fea727525f50939244c0f0cd1)
* hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java


> Failed MiniZooKeeperCluster startup did not shutdown ZK servers
> ---------------------------------------------------------------
>
>                 Key: HBASE-13733
>                 URL: https://issues.apache.org/jira/browse/HBASE-13733
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>             Fix For: 2.0.0, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13733.v1.patch
>
>
> MiniZooKeeperCluster#startup() starts servers one-by-one, if everything is good, it would
declare success of start:
> {code}
>   public int startup(File baseDir, int numZooKeeperServers) 
>     ...
>     // running all the ZK servers
>     for (int i = 0; i < numZooKeeperServers; i++) {
>     ...===> could throw exception in the loop and end the startup
>       // Start up this ZK server
>       standaloneServerFactory.startup(server);
>       ...
>       standaloneServerFactoryList.add(standaloneServerFactory);
>       zooKeeperServers.add(server);
>     }
>    ...
>     started = true;
>     ...
>   }
> {code}
> However, if exception throws in the middle of start up (eg. some servers already started),
the MiniZooKeeperCluster#shutdown() would not shut down them and clean up resources.  
> {code}
>   public void shutdown() throws IOException {
>     if (!started) {
>       return;
>     }
>     ...
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message