hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13733) failed MiniZooKeeperCluster startup not shut down ZK servers
Date Thu, 21 May 2015 20:19:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554975#comment-14554975
] 

Hadoop QA commented on HBASE-13733:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12734599/HBASE-13733.v1.patch
  against master branch at commit cb1ef915df5be4d1be2928cbe84ee9c00c5ea2ac.
  ATTACHMENT ID: 12734599

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14147//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14147//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14147//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14147//console

This message is automatically generated.

> failed MiniZooKeeperCluster startup not shut down ZK servers
> ------------------------------------------------------------
>
>                 Key: HBASE-13733
>                 URL: https://issues.apache.org/jira/browse/HBASE-13733
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>             Fix For: 2.0.0, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13733.v1.patch
>
>
> MiniZooKeeperCluster#startup() starts servers one-by-one, if everything is good, it would
declare success of start:
> {code}
>   public int startup(File baseDir, int numZooKeeperServers) 
>     ...
>     // running all the ZK servers
>     for (int i = 0; i < numZooKeeperServers; i++) {
>     ...===> could throw exception in the loop and end the startup
>       // Start up this ZK server
>       standaloneServerFactory.startup(server);
>       ...
>       standaloneServerFactoryList.add(standaloneServerFactory);
>       zooKeeperServers.add(server);
>     }
>    ...
>     started = true;
>     ...
>   }
> {code}
> However, if exception throws in the middle of start up (eg. some servers already started),
the MiniZooKeeperCluster#shutdown() would not shut down them and clean up resources.  
> {code}
>   public void shutdown() throws IOException {
>     if (!started) {
>       return;
>     }
>     ...
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message