hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13733) failed MiniZooKeeperCluster startup not shut down ZK servers
Date Thu, 21 May 2015 12:59:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554241#comment-14554241
] 

Ted Yu commented on HBASE-13733:
--------------------------------

dev-support/findHangingTests.py reported:
{code}
Fetching the console output from the URL
Printing hanging tests
Hanging test : org.apache.hadoop.hbase.TestIOFencing
Hanging test : org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
Hanging test : org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Hanging test : org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
Hanging test : org.apache.hadoop.hbase.mapreduce.TestCopyTable
Hanging test : org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
Printing Failing tests
{code}
Please see if the above tests pass for you locally.
If so, mind re-attaching the patch ?

> failed MiniZooKeeperCluster startup not shut down ZK servers
> ------------------------------------------------------------
>
>                 Key: HBASE-13733
>                 URL: https://issues.apache.org/jira/browse/HBASE-13733
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>             Fix For: 2.0.0, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13733.patch
>
>
> MiniZooKeeperCluster#startup() starts servers one-by-one, if everything is good, it would
declare success of start:
> {code}
>   public int startup(File baseDir, int numZooKeeperServers) 
>     ...
>     // running all the ZK servers
>     for (int i = 0; i < numZooKeeperServers; i++) {
>     ...===> could throw exception in the loop and end the startup
>       // Start up this ZK server
>       standaloneServerFactory.startup(server);
>       ...
>       standaloneServerFactoryList.add(standaloneServerFactory);
>       zooKeeperServers.add(server);
>     }
>    ...
>     started = true;
>     ...
>   }
> {code}
> However, if exception throws in the middle of start up (eg. some servers already started),
the MiniZooKeeperCluster#shutdown() would not shut down them and clean up resources.  
> {code}
>   public void shutdown() throws IOException {
>     if (!started) {
>       return;
>     }
>     ...
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message