hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13713) See about dropping ClassLoaderBase#getClassLoadingLock
Date Tue, 19 May 2015 22:47:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551387#comment-14551387
] 

Hadoop QA commented on HBASE-13713:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733932/HBASE-13713.patch
  against master branch at commit 74e5b26e57ef8d31723ff05ff913bad7f92a7518.
  ATTACHMENT ID: 12733932

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14096//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14096//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14096//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14096//console

This message is automatically generated.

> See about dropping ClassLoaderBase#getClassLoadingLock
> ------------------------------------------------------
>
>                 Key: HBASE-13713
>                 URL: https://issues.apache.org/jira/browse/HBASE-13713
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Lars Francke
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-13713.patch
>
>
> From the comment in ClassLoaderBase
> {noformat}
> /**
>  * Base class loader that defines couple shared constants used
>  * by sub-classes. It also defined method getClassLoadingLock for parallel
>  * class loading and JDK 1.6 support. This method (getClassLoadingLock)
>  * is similar to the same method in the base class Java ClassLoader
>  * introduced in JDK 1.7, but not in JDK 1.6.
>  */
> {noformat}
> We've dropped JDK6 support, so let's see if we can post a red-patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message