hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13711) Provide an API to set min and max versions in HColumnDescriptor
Date Tue, 19 May 2015 22:28:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551362#comment-14551362
] 

Hadoop QA commented on HBASE-13711:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733930/HBASE-13711-v2.patch
  against master branch at commit 74e5b26e57ef8d31723ff05ff913bad7f92a7518.
  ATTACHMENT ID: 12733930

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14094//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14094//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14094//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14094//console

This message is automatically generated.

> Provide an API to set min and max versions in HColumnDescriptor
> ---------------------------------------------------------------
>
>                 Key: HBASE-13711
>                 URL: https://issues.apache.org/jira/browse/HBASE-13711
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>            Priority: Minor
>             Fix For: 2.0.0, 0.98.14, 1.2.0
>
>         Attachments: HBASE-13711-v2.patch, HBASE-13711.patch
>
>
> In org.apache.hadoop.hbase.chaos.actions.ChangeVersionsAction#perform(), it tries to
update the max and min versions in a column descriptor: 
> {code}
>      for(HColumnDescriptor descriptor:columnDescriptors) {
>        descriptor.setMaxVersions(versions);
>        descriptor.setMinVersions(versions);
>      }
> {code}
> If the current minimum version is greater than the new max version, an IllegalArgumentException
would throw from org.apache.hadoop.hbase.HColumnDescriptor#setMaxVersions().  
> Here is an example (trying to set max version to 1 while currently min version is 2):
> {noformat}
> java.lang.IllegalArgumentException: Set MaxVersion to 1 while minVersion is 2. Maximum
versions must be >= minimum versions
> at org.apache.hadoop.hbase.HColumnDescriptor.setMaxVersions(HColumnDescriptor.java:634)
> at org.apache.hadoop.hbase.chaos.actions.ChangeVersionsAction.perform(ChangeVersionsAction.java:62)
> {noformat}
> One solution is to change the order of set - set min version first and then set max version
(note: the current implement of org.apache.hadoop.hbase.HColumnDescriptor#setMinVersions()
does not check the min version value and blindly set the version.  Not sure whether this is
by-design).
> Another solution is to provide an API to set both min and max version in one function
call.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message