hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13710) Remove use of Hadoop's ReflectionUtil in favor of our own.
Date Wed, 20 May 2015 20:45:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553075#comment-14553075
] 

Hadoop QA commented on HBASE-13710:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733893/HBASE-13710.2.patch
  against master branch at commit 88f19ab6979c7012c3dd22b2f45db9f746c7736d.
  ATTACHMENT ID: 12733893

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s): 	at org.apache.hadoop.hbase.wal.TestWALSplit.testCorruptedFileGetsArchivedIfSkipErrors(TestWALSplit.java:520)
	at org.apache.hadoop.hbase.wal.TestWALSplit.testLogsGetArchivedAfterSplit(TestWALSplit.java:648)
	at org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster.testReplayedEditsAreSkipped(TestRegionReplicaReplicationEndpointNoMaster.java:295)
	at org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager.test(TestReplicationWALReaderManager.java:169)
	at org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaReplicationIgnoresDisabledTables(TestRegionReplicaReplicationEndpoint.java:349)
	at org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaReplicationIgnoresDroppedTables(TestRegionReplicaReplicationEndpoint.java:335)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14118//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14118//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14118//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14118//console

This message is automatically generated.

> Remove use of Hadoop's ReflectionUtil in favor of our own.
> ----------------------------------------------------------
>
>                 Key: HBASE-13710
>                 URL: https://issues.apache.org/jira/browse/HBASE-13710
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: HBASE-13710.1.patch, HBASE-13710.2.patch
>
>
> HttpServer makes use of Hadoop's ReflectionUtil instead of our own. AFAICT it's using
1 extra method. Just copy that one over to our own ReflectionUtil.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message