hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13703) ReplicateContext should not be a member of ReplicationSource
Date Fri, 22 May 2015 06:55:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555694#comment-14555694
] 

Hudson commented on HBASE-13703:
--------------------------------

FAILURE: Integrated in HBase-1.0 #927 (See [https://builds.apache.org/job/HBase-1.0/927/])
HBASE-13703 ReplicateContext should not be a member of ReplicationSource. (larsh: rev fb09dead1d464d972adf14c018ad8edbc2aa5c2d)
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java


> ReplicateContext should not be a member of ReplicationSource
> ------------------------------------------------------------
>
>                 Key: HBASE-13703
>                 URL: https://issues.apache.org/jira/browse/HBASE-13703
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 2.0.0, 0.98.13, 1.0.2, 1.1.1
>
>         Attachments: 13703.txt
>
>
> The ReplicateContext object is created once per ReplicationSource and then reused when
we have something to ship to the sinks.
> This is a misguided optimization. ReplicateContext is very lightweight (definitely compared
to the all the work and copying the ReplicationSource is doing) and, crucially, it prevent
the the entries array from being collected after it was successfully copied to the sink, wasting
potentially a lot of heap.
> The entries array itself holds reference to WAL entries on the heap, that now also cannot
be collected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message