hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13703) ReplicateContext should not be a member of ReplicationSource
Date Mon, 18 May 2015 05:38:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547558#comment-14547558

ramkrishna.s.vasudevan commented on HBASE-13703:

LGTM. The ReplicationContext is anyway passed to the ReplicationEndpoint and also the ReplicationSourceInterface
does not try to create Replicationcontext as a member variable in the init() params.

Also ReplicationContext object does not need any state variable from the ReplicatonSource
where it is getting created (for now).  Even VisibilityReplicationEndpoint just tries to use
the ReplicationContext that is passed to it via the replicate(ReplicationContext) API.  

> ReplicateContext should not be a member of ReplicationSource
> ------------------------------------------------------------
>                 Key: HBASE-13703
>                 URL: https://issues.apache.org/jira/browse/HBASE-13703
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>         Attachments: 13703.txt
> The ReplicateContext object is created once per ReplicationSource and then reused when
we have something to ship to the sinks.
> This is a misguided optimization. ReplicateContext is very lightweight (definitely compared
to the all the work and copying the ReplicationSource is doing) and, crucially, it prevent
the the entries array from being collected after it was successfully copied to the sink, wasting
potentially a lot of heap.
> The entries array itself holds reference to WAL entries on the heap, that now also cannot
be collected.

This message was sent by Atlassian JIRA

View raw message