hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13698) Add RegionLocator methods to Thrift2 proxy.
Date Tue, 19 May 2015 05:34:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549811#comment-14549811
] 

Hadoop QA commented on HBASE-13698:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733691/HBASE-13698.patch
  against master branch at commit 92e66ef5222391d106bc8adb7afe7d96a7dafac2.
  ATTACHMENT ID: 12733691

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1899 checkstyle
errors (more than the master's current 1898 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      exists_call method_call = new exists_call(table, tget, resultHandler, this, ___protocolFactory,
___transport);
+      get_call method_call = new get_call(table, tget, resultHandler, this, ___protocolFactory,
___transport);
+      getMultiple_call method_call = new getMultiple_call(table, tgets, resultHandler, this,
___protocolFactory, ___transport);
+      put_call method_call = new put_call(table, tput, resultHandler, this, ___protocolFactory,
___transport);
+      checkAndPut_call method_call = new checkAndPut_call(table, row, family, qualifier,
value, tput, resultHandler, this, ___protocolFactory, ___transport);
+      putMultiple_call method_call = new putMultiple_call(table, tputs, resultHandler, this,
___protocolFactory, ___transport);
+      deleteSingle_call method_call = new deleteSingle_call(table, tdelete, resultHandler,
this, ___protocolFactory, ___transport);
+      deleteMultiple_call method_call = new deleteMultiple_call(table, tdeletes, resultHandler,
this, ___protocolFactory, ___transport);
+      checkAndDelete_call method_call = new checkAndDelete_call(table, row, family, qualifier,
value, tdelete, resultHandler, this, ___protocolFactory, ___transport);
+      increment_call method_call = new increment_call(table, tincrement, resultHandler, this,
___protocolFactory, ___transport);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestFastFail
                  org.apache.hadoop.hbase.util.TestProcessBasedCluster
                  org.apache.hadoop.hbase.mapreduce.TestImportExport

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s): 	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:287)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:261)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:255)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:239)
	at org.apache.hadoop.hbase.procedure.TestZKProcedure.testMultiCohortWithMemberTimeoutDuringPrepare(TestZKProcedure.java:311)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14082//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14082//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14082//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14082//console

This message is automatically generated.

> Add RegionLocator methods to Thrift2 proxy.
> -------------------------------------------
>
>                 Key: HBASE-13698
>                 URL: https://issues.apache.org/jira/browse/HBASE-13698
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13698.patch
>
>
> Thrift2 doesn't provide the same functionality as the java client for getting region
locations. We should change that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message