hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13685) Procedure v2 - Add maxProcId to the wal header
Date Thu, 14 May 2015 04:48:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543178#comment-14543178
] 

Hadoop QA commented on HBASE-13685:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12732745/HBASE-13685-v0.patch
  against master branch at commit 94937ddaf25b6eac69b2c7de1c127f9d3de12306.
  ATTACHMENT ID: 12732745

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      "(\004\022\017\n\007updated\030\002 \003(\004\022\017\n\007deleted\030\003 \003(\004\"\266\001\n"
+
+      "\020\001\022\010\n\004INIT\020\002\022\n\n\006INSERT\020\003\022\n\n\006UPDATE\020\004\022\n\n\006"
+

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14041//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14041//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14041//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14041//console

This message is automatically generated.

> Procedure v2 - Add maxProcId to the wal header
> ----------------------------------------------
>
>                 Key: HBASE-13685
>                 URL: https://issues.apache.org/jira/browse/HBASE-13685
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 1.1.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Blocker
>             Fix For: 1.1.0
>
>         Attachments: HBASE-13685-v0.patch
>
>
> while working on HBASE-13476 I found that having the max-proc-id in the wal header, allows
some nice optimizations.
> [~ndimiduk] since 1.1 is not released yet, can we get this in so we can avoid all extra
handling?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message