hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13679) Change ColumnTracker and SQM to deal with Cell instead of byte[], int, int
Date Wed, 13 May 2015 13:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541935#comment-14541935
] 

Hadoop QA commented on HBASE-13679:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12732548/HBASE-13679.patch
  against master branch at commit 220ac141bfcea7798faa5f73295ec61d8b173af9.
  ATTACHMENT ID: 12732548

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 7 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1898 checkstyle
errors (more than the master's current 1896 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14036//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14036//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14036//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14036//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14036//console

This message is automatically generated.

> Change ColumnTracker and SQM to deal with Cell instead of byte[], int, int
> --------------------------------------------------------------------------
>
>                 Key: HBASE-13679
>                 URL: https://issues.apache.org/jira/browse/HBASE-13679
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: HBASE-13679.patch
>
>
> We deal with rowArray and qualifierArray in these classes.  Instead keep ref to current/previous
cells and use Cell based compares/matching.
> Again this will increase the number of calls to getXXXOffset/Length. HBASE-13448 has
to go in before this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message