hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13677) RecoverableZookeeper WARNs on expected events
Date Mon, 18 May 2015 02:21:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547458#comment-14547458
] 

Sean Busbey commented on HBASE-13677:
-------------------------------------

Overall, the patch looks good. We don't have any regular means of testing log messages, sadly.

It looks like there are some additional messages in the delete method that are basically "already
deleted, presume we did it earlier" at INFO. Could you tune these down to DEBUG as well?

some nits:

* A patch this simple usually doesn't need a review board.
* In the future, please generate your patch files using format-patch so that your authorship
and commit message will already be in place. e.g. {{git format-patch --stdout origin/master
> HBASE-13677.1.patch}}

> RecoverableZookeeper WARNs on expected events
> ---------------------------------------------
>
>                 Key: HBASE-13677
>                 URL: https://issues.apache.org/jira/browse/HBASE-13677
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Nick Dimiduk
>            Assignee: Ted Malaska
>            Priority: Minor
>              Labels: beginner
>             Fix For: 1.1.1
>
>         Attachments: HBASE-13677.patch
>
>
> Noticed in the logs while verifying an RC, running a simple LTT in local mode resulted
in half a dozen lines like
> {noformat}
> 2015-05-12 13:58:42,949 WARN  [M:0;10.0.0.110:50866] zookeeper.RecoverableZooKeeper:
Possibly transient ZooKeeper, quorum=localhost:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException:
KeeperErrorCode = ConnectionLoss for /hbase/hbaseid
> {noformat}
> A class called "RecoverableZooKeeper" should be expecting "possibly transient" events
relating to "ZooKeeper". Let's drop this to DEBUG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message