hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13655) Deprecate duplicate getCompression methods in HColumnDescriptor
Date Mon, 11 May 2015 00:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537439#comment-14537439
] 

Hadoop QA commented on HBASE-13655:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12731821/HBASE-13655.patch
  against master branch at commit 7bdacf53f41d7e3c6c6698c5d20fdcebaa10a1bb.
  ATTACHMENT ID: 12731821

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +          "(reader: " + reader + ")", hcd.getCompressionType(), reader.getFileContext().getCompression());
+          "(reader: " + reader + ")", hcd.getCompressionType(), reader.getFileContext().getCompression());
+    StoreFile.Writer writer = store.createWriterInTmp(4, hcd.getCompressionType(), false,
true, false);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14001//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14001//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14001//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14001//console

This message is automatically generated.

> Deprecate duplicate getCompression methods in HColumnDescriptor
> ---------------------------------------------------------------
>
>                 Key: HBASE-13655
>                 URL: https://issues.apache.org/jira/browse/HBASE-13655
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HBASE-13655-v1.patch, HBASE-13655.patch
>
>
> {{HColumnDescriptor}} has {{getCompression}} and {{getCompressionType}} methods returning
the same thing. The same goes for {{getCompactionCompression}} and {{getCompactionCompressionType}}.
> This deprecates the methods without {{Type}} in 2.0.0 so they can be removed in 3.0.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message