hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13651) Handle StoreFileScanner FileNotFoundException
Date Sun, 10 May 2015 04:27:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537019#comment-14537019

stack commented on HBASE-13651:

On below:

	      // TODO: add support for abort() of a single region and trigger reassignment.

Good idea. Closing the region and allowing notification of zk to proceed doesn't work as a
means of signaling the master to reassign?

bq. 	            incNextSeqCall = true;

Keeping the increment at this location and decrementing in finally if failure won't work?
(The increment looked like it'd protect against crazy client doing a new request reusing previous
seq call number.)  You figured something Matteo?

nit: Why two LOG.errors here, one after the other? Why not just the one log line?

5784	        LOG.error(msg);
5785	        LOG.error("unable to refresh store files", e);

> Handle StoreFileScanner FileNotFoundException
> ---------------------------------------------
>                 Key: HBASE-13651
>                 URL: https://issues.apache.org/jira/browse/HBASE-13651
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.27,
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>         Attachments: HBASE-13651-0.94-draft.patch, HBASE-13651-draft.patch
> Example:
>  * Machine-1 is serving Region-X and start compaction
>  * Machine-1 goes in GC pause
>  * Region-X gets reassigned to Machine-2
>  * Machine-1 exit from the GC pause
>  * Machine-1 (re)moves the compacted files
>  * Machine-1 get the lease expired and shutdown
> Machine-2 has now tons of FileNotFoundException on scan. If we reassign the region everything
is ok, because we pickup the files compacted by Machine-1.
> This problem doesn't happen in the new code 1.0+  (i think but I haven't checked, it
may be 1.1) where we write on the WAL the compaction event before (re)moving the files.
> A workaround is handling FileNotFoundException and refresh the store files, or shutdown
the region and reassign. the first one is easy in 1.0+ the second one requires more work because
at the moment we don't have the code to notify the master that the RS is closing the region,
alternatively we can shutdown the entire RS (it is not a good solution but the case is rare

This message was sent by Atlassian JIRA

View raw message