hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13646) HRegion#execService should not try to build incomplete messages
Date Mon, 11 May 2015 04:31:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537549#comment-14537549
] 

stack commented on HBASE-13646:
-------------------------------

Patch looks good [~octo47] What is the context?

> HRegion#execService should not try to build incomplete messages
> ---------------------------------------------------------------
>
>                 Key: HBASE-13646
>                 URL: https://issues.apache.org/jira/browse/HBASE-13646
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, regionserver
>    Affects Versions: 2.0.0, 1.2.0, 1.1.1
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>         Attachments: HBASE-13646.patch, HBASE-13646.v2.patch
>
>
> If some RPC service, called on region throws exception, execService still tries to build
Message. In case of complex messages with required fields it complicates service code because
service need to pass fake protobuf objects, so they can be barely buildable. 
> To mitigate that I propose to check that controller was failed and return null from call
instead of failing with exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message