hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Stepachev (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-13646) HRegion#execService should not try to build incomplete messages
Date Fri, 08 May 2015 12:07:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534402#comment-14534402
] 

Andrey Stepachev edited comment on HBASE-13646 at 5/8/15 12:07 PM:
-------------------------------------------------------------------

Patch:
1. Checking that we have exception and throw it.
2. Fixing wrong controller used to call (that is why checks didn't work actually)

(and have long lines because of HBASE-13648)


was (Author: octo47):
have long lines because of HBASE-13648

> HRegion#execService should not try to build incomplete messages
> ---------------------------------------------------------------
>
>                 Key: HBASE-13646
>                 URL: https://issues.apache.org/jira/browse/HBASE-13646
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, regionserver
>    Affects Versions: 2.0.0, 1.2.0, 1.1.1
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>         Attachments: HBASE-13646.patch
>
>
> If some RPC service, called on region throws exception, execService still tries to build
Message. In case of complex messages with required fields it complicates service code because
service need to pass fake protobuf objects, so they can be barely buildable. 
> To mitigate that I propose to check that controller was failed and return null from call
instead of failing with exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message