hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13646) HRegion#execService should not try to build incomplete messages
Date Fri, 15 May 2015 19:52:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546084#comment-14546084
] 

Nick Dimiduk commented on HBASE-13646:
--------------------------------------

What [~stack] said :)

This would make it so some coproc running on 1.1.x would be experiencing different environment
from running on 1.1.(x+1), so I think it's not acceptable as a semver "patch" level change.
Thus please no for branch-1.0 or branch-1.1.

> HRegion#execService should not try to build incomplete messages
> ---------------------------------------------------------------
>
>                 Key: HBASE-13646
>                 URL: https://issues.apache.org/jira/browse/HBASE-13646
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, regionserver
>    Affects Versions: 2.0.0, 1.2.0, 1.1.1
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13646-branch-1.patch, HBASE-13646.patch, HBASE-13646.v2.patch,
HBASE-13646.v2.patch
>
>
> If some RPC service, called on region throws exception, execService still tries to build
Message. In case of complex messages with required fields it complicates service code because
service need to pass fake protobuf objects, so they can be barely buildable. 
> To mitigate that I propose to check that controller was failed and return null from call
instead of failing with exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message