hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13641) Deperecate Filter#filterRowKey(byte[] buffer, int offset, int length) in favor of filterRowKey(Cell firstRowCell)
Date Thu, 21 May 2015 06:01:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553674#comment-14553674
] 

Hadoop QA commented on HBASE-13641:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12734333/HBASE-13641_V3.patch
  against master branch at commit 5e06ede3f7860ed47c7dd38f889b3535e757b257.
  ATTACHMENT ID: 12734333

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 15 new or modified
tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail with
Hadoop version 2.4.1.

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java:[120,28]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java:[120,36]
cannot find symbol
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile
(default-compile) on project hbase-client: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java:[120,28]
cannot find symbol
[ERROR] symbol:   variable buffer
[ERROR] location: class org.apache.hadoop.hbase.filter.MultiRowRangeFilter
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java:[120,36]
cannot find symbol
[ERROR] symbol:   variable offset
[ERROR] location: class org.apache.hadoop.hbase.filter.MultiRowRangeFilter
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-client
    

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14138//console

This message is automatically generated.

> Deperecate Filter#filterRowKey(byte[] buffer, int offset, int length) in favor of filterRowKey(Cell
firstRowCell)
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13641
>                 URL: https://issues.apache.org/jira/browse/HBASE-13641
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Filters, regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13641.patch, HBASE-13641.patch, HBASE-13641_V2.patch, HBASE-13641_V3.patch
>
>
> This is in path towards HBASE-13387
> When the scan contains any filter, we have to call the filterRowKey(byte[],int,int) API.
 (Even if it is not interested in this method)
> When the Cells coming in is offheap backed, we would need temp byte[] creation and copy
row bytes to that.  If we can make this Filter API to take a cell (which is the first cell
in any row), we can avoid this overhead.
> In 2.0.0 we will deprecate the old API with addition of new and FilterBase will give
BC for old style custom Filters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message