hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13634) Avoid unsafe reference equality checks to EMPTY byte[]
Date Thu, 07 May 2015 14:57:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532801#comment-14532801
] 

Hadoop QA commented on HBASE-13634:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12730866/HBASE-13634.patch
  against master branch at commit 11b76732c0ec80a2cccbe7937440bd107e577c8b.
  ATTACHMENT ID: 12730866

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestStripeStoreFileManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13977//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13977//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13977//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13977//console

This message is automatically generated.

> Avoid unsafe reference equality checks to EMPTY byte[]
> ------------------------------------------------------
>
>                 Key: HBASE-13634
>                 URL: https://issues.apache.org/jira/browse/HBASE-13634
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, Scanners
>            Reporter: Dave Latham
>            Assignee: Lars Francke
>             Fix For: 2.0.0, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13634.patch
>
>
> While looking to see if there was a standard method in the code base for testing for
the empty start and end row, I noticed some cases that are using unsafe reference equality
checks and thus may have incorrect behavior in boundary cases:
> ScanQueryMatcher.checkPartialDropDeleteRange
> StripeStoreFileManager.findStripeForRow
> It looks like both are intended to support stripe compaction



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message