hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13634) Unsafe reference equality checks to EMPTY_START_ROW
Date Wed, 06 May 2015 16:16:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars Francke updated HBASE-13634:
---------------------------------
    Attachment: HBASE-13634.patch

I've done a quick patch that fixes all unsafe reference checks with Arrays I could find. I
have to admit that I did not spend much time trying to understand the code to see if any of
them might have been intentional.

Let's see what Jenkins has to say about this...

> Unsafe reference equality checks to EMPTY_START_ROW
> ---------------------------------------------------
>
>                 Key: HBASE-13634
>                 URL: https://issues.apache.org/jira/browse/HBASE-13634
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, Scanners
>            Reporter: Dave Latham
>         Attachments: HBASE-13634.patch
>
>
> While looking to see if there was a standard method in the code base for testing for
the empty start and end row, I noticed some cases that are using unsafe reference equality
checks and thus may have incorrect behavior in boundary cases:
> ScanQueryMatcher.checkPartialDropDeleteRange
> StripeStoreFileManager.findStripeForRow
> It looks like both are intended to support stripe compaction



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message