hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13598) Make hbase assembly 'attach' to the project
Date Sat, 02 May 2015 00:57:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524412#comment-14524412
] 

Jerry He commented on HBASE-13598:
----------------------------------

I think there are two separate things here.

The patch only provides/adds the possibility of install/deploy the tarball IF people choose
to do so, e.g. for people doing their local build and/or as part of build of other projects.
Not allowing the possibility of doing this in any circumstance sounds like a bug or limitation.

The second thing raised here is whether we deploy the assembly tarball during release. I understand
the rationale raised by [~apurtell] from a RM or release perspective.  We can discuss it further.
With this patch, it is still safe NOT to deploy the assembly tarball during release.  I can
put a note in the book under the Release section.

Just did a quick check for Hive out of curiosity: 
Hive deploys the SNAPSHOT tarball on Maven:  https://repository.apache.org/content/repositories/snapshots/org/apache/hive/hive-packaging/1.2.0-SNAPSHOT/
But for release, it does not deploy the tarball:  https://repository.apache.org/content/repositories/releases/org/apache/hive/hive-packaging/1.1.0/

> Make hbase assembly 'attach' to the project
> -------------------------------------------
>
>                 Key: HBASE-13598
>                 URL: https://issues.apache.org/jira/browse/HBASE-13598
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13598-master.patch
>
>
> Currently for hbase assembly, we set 'attach' to 'false':
> hbase-assembly/pom.xml:
> {code}
> <!--We do not want assembly attached; run on command-line explicitly
> -               if you want to do an assembly-->
> -          <attach>false</attach>
> {code}
> The result is that the hbase assembly tarball will not be deployed via 'mvn install'
or 'maven deploy'
> There are Apache projects that directly uses the hbase assembly tarball in their build
process.  For example, Slider HBase package and Ambari 2.0 Metrics.
> Here is the link the maven assembly plug info on the 'attach':
> https://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#attach
> {code}
> attach:
> Controls whether the assembly plugin tries to attach the resulting assembly to the project.
> Type: boolean
> Since: 2.2-beta-1
> Required: No
> User Property: assembly.attach
> Default: true
> {code}
> The assembly will only be built if 'assembly:single' is specified, and then deployed
in 'maven install' or 'maven deploy'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message