hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13581) Improve usability for storefile stats in web status pages
Date Thu, 07 May 2015 12:29:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532535#comment-14532535
] 

Hadoop QA commented on HBASE-13581:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12731131/HBASE-13581.patch
  against master branch at commit 11b76732c0ec80a2cccbe7937440bd107e577c8b.
  ATTACHMENT ID: 12731131

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +              new java.lang.String[] { "RegionSpecifier", "Stores", "Storefiles", "StoreUncompressedSize",
"StorefileSize", "MemstoreSizeMB", "StorefileIndexSizeMB", "ReadRequestsCount", "WriteRequestsCount",
"TotalCompactingKVs", "CurrentCompactedKVs", "RootIndexSize", "TotalStaticIndexSize", "TotalStaticBloomSize",
"CompleteSequenceId", "DataLocality", "LastMajorCompactionTs", "StoreCompleteSequenceId",
});
+      "\312\002\n\006Region\022\014\n\004name\030\001 \002(\014\022\016\n\006stores\030\002
\001(\005" +
+      "tedKVs\030\r \001(\003\032\303\001\n\004Node\022\014\n\004name\030\001 \002(\t\022\021\n\ts"
+
+              new java.lang.String[] { "Name", "Stores", "Storefiles", "StorefileSize", "MemstoreSizeMB",
"StorefileIndexSizeMB", "ReadRequestsCount", "WriteRequestsCount", "RootIndexSize", "TotalStaticIndexSize",
"TotalStaticBloomSize", "TotalCompactingKVs", "CurrentCompactedKVs", });
+      "rootIndexSize=\"1\" storefileIndexSizeMB=\"0\" storefileSize=\"0\" storefiles=\"1\"
stores=\"1\" " +
+      "totalCompactingKVs=\"1\" totalStaticBloomSize=\"1\" totalStaticIndexSize=\"1\" writeRequestsCount=\"2\"/>"
+
+      "readRequestsCount=\"1\" rootIndexSize=\"1\" storefileIndexSizeMB=\"0\" storefileSize=\"0\"
" +
+            .setStorefileIndexSizeMB(42).setRootIndexSize(201).setReadRequestsCount(Integer.MAX_VALUE).setWriteRequestsCount(Integer.MAX_VALUE).build();
+            .setStorefileIndexSizeMB(40).setRootIndexSize(303).setReadRequestsCount(Integer.MAX_VALUE).setWriteRequestsCount(Integer.MAX_VALUE).build();

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13972//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13972//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13972//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13972//console

This message is automatically generated.

> Improve usability for storefile stats in web status pages
> ---------------------------------------------------------
>
>                 Key: HBASE-13581
>                 URL: https://issues.apache.org/jira/browse/HBASE-13581
>             Project: HBase
>          Issue Type: Improvement
>          Components: Operability
>    Affects Versions: 1.0.0
>            Reporter: Sean Busbey
>            Assignee: Ashutosh Jindal
>            Priority: Minor
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13581.patch, rs_in_master_status_page.tiff
>
>
> Right now the "Storefiles" section of the Region Servers status shown in the Master web
ui is inconsistent in units (sometimes "m" and sometimes "mb") and uses units that are fixed
rather than adapting to the number being presented (e.g. reporting a bloom filter size of
13540k instead of 13m).
> Clean up to
> * consistently use correct units (i.e. KiB, MiB, GiB since that's what we're measuring)
> * adapt the units used so that we use the biggest ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message