hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13579) Avoid isCellTTLExpired() for NO-TAG cases
Date Wed, 06 May 2015 07:08:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530059#comment-14530059
] 

Hadoop QA commented on HBASE-13579:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12730706/HBASE-13579_0.98.patch
  against 0.98 branch at commit 2e132db85c49373b4086f4e4f7b39dcf2972f24f.
  ATTACHMENT ID: 12730706

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 25 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 3832 checkstyle
errors (more than the master's current 3830 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.util.TestProcessBasedCluster
                  org.apache.hadoop.hbase.mapreduce.TestImportExport

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.camel.component.jetty.jettyproducer.JettyHttpProducerConcurrentTest.testNoConcurrentProducers(JettyHttpProducerConcurrentTest.java:47)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13954//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13954//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13954//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13954//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13954//console

This message is automatically generated.

> Avoid isCellTTLExpired() for NO-TAG cases
> -----------------------------------------
>
>                 Key: HBASE-13579
>                 URL: https://issues.apache.org/jira/browse/HBASE-13579
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>    Affects Versions: 1.0.0, 1.0.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 1.1.0, 0.98.14, 1.0.2, 1.2.0
>
>         Attachments: HBASE-13579_0.98.patch, HBASE-13579_0.98_1.patch, HBASE-13579_1.patch,
HBASE-13579_2.patch, HBASE-13579_KVExtension.patch, HBASE-13579_branch-1.patch, HBASE-13579_branch-1_1.patch,
HBASE-13579_storelevel.patch
>
>
> As observed in this JIRA's performance test, we are always calling the isCellTTLExpired()
for every cell and internally it is parsing the keyLength, valueLength() to get the tagsLength
after which we decide whether Cell level TTL is present are not.
> This JIRA aims to avoid this check if all the readers of the storescanner knows that
there are no tags to read.  Note that, for the memstore scanner we will do that in another
JIRA, which I suppose Stack had already raised to avoid tag length while flushing (for the
NO-TAG) case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message