hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13510) Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
Date Tue, 05 May 2015 11:41:59 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ramkrishna.s.vasudevan updated HBASE-13510:
-------------------------------------------
    Attachment: HBASE-13510_1.patch

This patch tries to refactor CompoundBloomFilter so that it could make use of CellComparator.compare(Cell,
Cell).  
The ByteBloomfilter cannot be purged totally because the 'chunks' inside the CompoundBloomFilter
are still ByteBloomFilters.  
But ByteBloomFilter cannot be a type of bloom because they are all removed since V1.


> Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
> -------------------------------------------------------------------------
>
>                 Key: HBASE-13510
>                 URL: https://issues.apache.org/jira/browse/HBASE-13510
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13510_1.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing Cell with a
serialized KV's key we had some need for that in Bloom filters.  After discussing with Anoop,
we found that it may be possible to remove/modify some of the APIs in the BloomFilter interfaces
and for doing that we can purge ByteBloomFilter.  
> I read the code and found that ByteBloomFilter was getting used in V1 version only. 
Now as it is obsolete we can remove this code and move some of the static APIs in ByteBloomFilter
to some other util class or bloom related classes which will help us in refactoring the code
too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message